Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use warning instead of error for cancelled mission #1882

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Use warning instead of error for cancelled mission #1882

merged 1 commit into from
Dec 16, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 13, 2024 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol force-pushed the recolor-part-success branch from 3afee5a to fb79181 Compare December 16, 2024 07:34
@Eddasol Eddasol marked this pull request as ready for review December 16, 2024 07:40
@Eddasol Eddasol self-assigned this Dec 16, 2024
@Eddasol Eddasol requested a review from andchiind December 16, 2024 07:40
@Eddasol Eddasol added the frontend Frontend related functionality label Dec 16, 2024
oysand
oysand approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol force-pushed the recolor-part-success branch from fb79181 to 5882334 Compare December 16, 2024 14:42
@Eddasol Eddasol merged commit 4ff7a1f into equinor:main Dec 16, 2024
12 checks passed
@Eddasol Eddasol deleted the recolor-part-success branch December 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysand oysand oysand approved these changes

@andchiind andchiind Awaiting requested review from andchiind

Assignees

@Eddasol Eddasol

Labels
frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @oysand